333 Commits

Author	SHA1	Message	Date
wxiaoguang	5aa62ac70b	Refactor tmpl and blob_excerpt (#32967) ... 1. do not use `{{/* */}}` to remove spaces, use `{{- -}}` 2. fix "blob_excerpt" endpoint, remove the legacy fragile code: have tested commit diff and wiki diff	2024-12-25 00:51:13 +08:00
wxiaoguang	a9db6d5d56	Fix "unicode escape" JS error (#32806) ... <details>     </details> --------- Co-authored-by: silverwind <me@silverwind.io>	2024-12-12 18:37:44 +00:00
wxiaoguang	f4b3d4a5d7	Refactor markdown editor and use it for milestone description editor (#32688) ... Refactor markdown editor to clarify its "preview" behavior and remove jQuery code. Close #15045 --------- Co-authored-by: silverwind <me@silverwind.io>	2024-12-04 02:11:34 +00:00
wxiaoguang	a2240ac960	Fix issue title rendering and refactor legacy function names (#32703) ... Fix #32700, regression of recent markup refactoring And by the way, clarify many legacy problems: 1. Some "RenderXxx" functions do not really "render", they only call "post processors" 2. Merge "RenderEmoji | RenderCodeBlock", they are all for "simple issue title"	2024-12-04 01:39:33 +00:00
Kerwin Bryant	0053b1ecf2	Fixed Issue of Review Menu Shown Behind (#32631) ... Fixed #31144 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-11-26 09:24:56 +08:00
silverwind	3a45cb964b	Add 'Copy path' button to file view (#32584) ... Also adds a tooltip which is replicated to the same button in the diff box. Fixes: https://github.com/go-gitea/gitea/issues/32583	2024-11-21 04:03:17 +00:00
wxiaoguang	a9aaed328b	Support quote selected comments to reply (#32431) ... Many existing tests were quite hacky, these could be improved later. <details>  </details>	2024-11-07 03:57:07 +00:00
wxiaoguang	8fdb975263	Refactor template ctx and render utils (#32422) ... Clean up the templates	2024-11-05 14:04:26 +08:00
wxiaoguang	25cfe8a5a6	Refactor DateUtils and merge TimeSince (#32409) ... Follow #32383 and #32402	2024-11-04 11:30:00 +00:00
wxiaoguang	d1053f7ec4	Replace DateTime with DateUtils (#32383)	2024-11-02 04:08:28 +00:00
wxiaoguang	6ef0e00943	Refactor image diff (#31444) ... And remove some jQuery functions	2024-06-22 04:52:09 +00:00
charles	fae969afdb	Fix the wrong line number in the diff view page when expanded twice. (#31431) ... close #31149, regression of #29385 (incorrect `data-query=`)	2024-06-20 17:43:42 +00:00
Kerwin Bryant	5adbfac6ad	code optimization (#31315) ... Simplifying complex if-else to existing Iif operations	2024-06-11 21:07:10 +08:00
silverwind	a5a48cb3d7	Use vertical layout for multiple code expander buttons (#31122) ... Fixes: https://github.com/go-gitea/gitea/issues/31068 - Now it only does a single call to `GetExpandDirection` per line instead of multiples. - Exposed `data-expand-direction` to frontend so it can correctly size the buttons (it's a pain to do in tables). <img width="142" alt="Screenshot 2024-05-27 at 20 44 56" src="https://github.com/go-gitea/gitea/assets/115237/8b0b45a6-8e50-4081-8822-5e0775d8d941"> <img width="142" alt="Screenshot 2024-05-27 at 20 44 51" src="https://github.com/go-gitea/gitea/assets/115237/b7ba2c57-8f55-4e9f-9606-c96d16b77892"> <img width="132" alt="Screenshot 2024-05-27 at 20 44 46" src="https://github.com/go-gitea/gitea/assets/115237/0e838fb8-5e8c-4250-9843-a68b88d5418b"> <img width="80" alt="Screenshot 2024-05-27 at 20 44 33" src="https://github.com/go-gitea/gitea/assets/115237/da6c7f83-c160-4389-8ab2-889d0568cbe8"> <img width="80" alt="Screenshot 2024-05-27 at 20 44 26" src="https://github.com/go-gitea/gitea/assets/115237/cdb490b2-5040-484a-92e5-46fc5e37c199"> <img width="78" alt="Screenshot 2024-05-27 at 20 44 20" src="https://github.com/go-gitea/gitea/assets/115237/d2978ab0-764e-41ff-922c-25f8fe749f28"> Would backport as trivial enhancement.	2024-05-29 06:08:45 +00:00
silverwind	38862baf26	Improve mobile review ui (#31091) ... Fixes: https://github.com/go-gitea/gitea/issues/31071 Not perfect but much better than before. Before: Overflows, sticky not working, filename unreadable: <img width="506" alt="Screenshot 2024-05-27 at 02 02 40" src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f"> After: <img width="457" alt="Screenshot 2024-05-27 at 01 59 06" src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">	2024-05-28 13:41:37 +00:00
metiftikci	d0ed4f81cd	Prevent simultaneous editing of comments and issues (#31053) ... fixes #22907 Tested: - [x] issue content edit - [x] issue content change tasklist - [x] pull request content edit - [x] pull request change tasklist 	2024-05-27 15:34:18 +00:00
delvh	f49af611cd	Simplify review UI (#31062) ... Instead of always displaying all available actions as buttons, merge them into a single dropdown menu, same as GitHub. That decreases visual overload and is more mobile-friendly, while not losing any functionality. ## Screenshots <details><summary>Before</summary>  </details> <details><summary>After (unexpanded)</summary>  </details> <details><summary>After (expanded)</summary>  </details>	2024-05-27 08:24:34 +00:00
wxiaoguang	f1cf7d37f4	Fix incorrect "blob excerpt" link when comparing files (#31013) ... When comparing files between the base repo and forked repo, the "blob excerpt" link should point to the forked repo, because the commit doesn't exist in base repo. Co-authored-by: Giteabot <teabot@gitea.io>	2024-05-20 05:57:57 +00:00
wxiaoguang	c24a07d042	Make Ctrl+Enter work for issue/comment edit (#30720) ... Fix #30710	2024-04-27 14:32:00 +00:00
Kemal Zebari	9c8d3a0fdf	Prevent allow/reject reviews on merged/closed PRs (#30686) ... Resolves #30675.	2024-04-27 11:55:03 +00:00
silverwind	5622e51ccd	Diff color enhancements, add line number background (#30670) ... 1. Bring back the background on line numbers. This feature was lost a long time ago. <img width="457" alt="Screenshot 2024-04-24 at 01 36 09" src="https://github.com/go-gitea/gitea/assets/115237/76a7f5a9-c22a-4c72-9f0a-ebf16a66513e"> <img width="473" alt="Screenshot 2024-04-24 at 01 22 47" src="https://github.com/go-gitea/gitea/assets/115237/eef06cf2-f1b9-40e3-947d-dd5852ec12a3"> <img width="457" alt="Screenshot 2024-04-24 at 02 13 18" src="https://github.com/go-gitea/gitea/assets/115237/59e317d4-76a7-468c-8a19-10d88c675cc3"> <img width="459" alt="Screenshot 2024-04-24 at 01 23 21" src="https://github.com/go-gitea/gitea/assets/115237/f1a46f8d-8846-4d78-a9d7-8b7dc18ac6e4"> 2. Expanded lines background is now full-line, including line numbers: <img width="1303" alt="Screenshot 2024-04-24 at 01 37 12" src="https://github.com/go-gitea/gitea/assets/115237/271eefe2-0869-424e-93fb-ccd8adc87806"> 3. Sort affected colors alphabetically in the CSS Fixes #14603	2024-04-26 19:37:21 +00:00
silverwind	dee8d3f24b	Remove fomantic button module (#30475) ... CSS-only module. Button colors are reduced to this: <img width="639" alt="Screenshot 2024-04-14 at 15 36 07" src="https://github.com/go-gitea/gitea/assets/115237/882d6c02-d1de-44f2-b707-db02a9f5070d"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-04-14 17:53:52 +00:00
silverwind	7b77283e8b	Rewrite and restyle reaction selector and enable no-sizzle eslint rule (#30453) ... Enable `no-sizzle` lint rule, there was only one use in `initCompReactionSelector` and: - Remove all jQuery except the necessary fomantic dropdown init - Remove the recursion, instead bind event listeners to common parent container nodes --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2024-04-14 18:44:11 +08:00
silverwind	c768163a74	Various improvements for long file and commit names (#30374) ... Fixes: https://github.com/go-gitea/gitea/issues/29438 This contains numerous enhancements for how large commit messages and large filenames render. Another notable change is that the file path is no longer cut off by backend at 30 chars, but rendered in full with wrapping. <img width="1329" alt="Screenshot 2024-04-09 at 21 53 57" src="https://github.com/go-gitea/gitea/assets/115237/5ccbb3d6-643a-4f60-ba79-3572b36d5182"> <hr> <img width="711" alt="Screenshot 2024-04-09 at 21 44 24" src="https://github.com/go-gitea/gitea/assets/115237/6ffe8fbb-407c-4aa7-b591-3d80daea7d57"> <hr> <img width="439" alt="Screenshot 2024-04-09 at 21 19 03" src="https://github.com/go-gitea/gitea/assets/115237/1ec7f6e9-2fd8-4841-87eb-6ca02ab9cd61"> <hr> <img width="444" alt="Screenshot 2024-04-09 at 21 18 52" src="https://github.com/go-gitea/gitea/assets/115237/70931b9e-5841-477e-b3bc-98f8d2662964"> --------- Co-authored-by: Giteabot <teabot@gitea.io>	2024-04-10 06:13:22 +00:00
silverwind	458ddb80a2	Migrate font-family to tailwind (#30118) ... Enable us to use tailwind's [`font-family`](https://tailwindcss.com/docs/font-family) classes as well as remove `gt-mono` in favor of `tw-font-mono`. I also merged the "compensation" to one selector, previously this was two different values 0.9em and 0.95em. I did not declare a `serif` font because I don't think there will ever be a use case for those. Command ran: ```sh perl -p -i -e 's#gt-mono#tw-font-mono#g' web_src/js/**/* templates/**/*	2024-03-28 08:31:07 +00:00
Lunny Xiao	3333a7e9fd	Put an edit file button on pull request files to allow a quick operation (#29697) ... Resolve #23848 This PR put an edit file button on pull request files to allow a quick edit for a file. After the edit finished, it will return back to the viewed file position on pull request files tab. It also use a branch view file link instead of commit link when it's a non-commit pull request files view. <img width="1532" alt="image" src="https://github.com/go-gitea/gitea/assets/81045/3637ca4c-89d5-4621-847b-79702a44f617"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>	2024-03-27 02:34:10 +00:00
silverwind	53414d38df	Add svg linter and fix incorrect svgs (#30086) ... Fixes https://github.com/go-gitea/gitea/issues/30082. Adds a new linter that searches for non-existant SVG images in templates. Output before the fix was: ``` $ make lint-templates SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl SVG "octicon-markup" not found, used in templates/repo/diff/comment_form.tmpl make: *** [Makefile:438: lint-templates] Error 1 ``` <img width="306" alt="Screenshot 2024-03-25 at 23 31 05" src="https://github.com/go-gitea/gitea/assets/115237/1052d1a9-bfec-4d5a-9cae-f895f78f7c93">	2024-03-26 11:19:15 +00:00
silverwind	d3c87bc994	Migrate gt-hidden to tw-hidden (#30046) ... We have to define this one in helpers.css because tailwind only generates a single class but certain things rely on this being double-class. Command ran: ```sh perl -p -i -e 's#gt-hidden#tw-hidden#g' web_src/js/**/* templates/**/* models/**/* web_src/css/**/* --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-03-24 18:23:38 +00:00
silverwind	4afc523456	Migrate margin and padding helpers to tailwind (#30043) ... This will conclude the refactor of 1:1 class replacements to tailwind, except `gt-hidden`. Commands ran: ```bash perl -p -i -e 's#gt-(p|m)([lrtbxy])?-0#tw-$1$2-0#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-1#tw-$1$2-0.5#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-2#tw-$1$2-1#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-3#tw-$1$2-2#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-4#tw-$1$2-4#g' {web_src/js,templates,routers,services}/**/* perl -p -i -e 's#gt-(p|m)([lrtbxy])?-5#tw-$1$2-8#g' {web_src/js,templates,routers,services}/**/* ```	2024-03-24 17:42:49 +01:00
silverwind	da2ab577a5	Migrate gap helpers to tailwind (#30034) ... Commands ran: ```sh perl -p -i -e 's#gt-gap-0#tw-gap-0#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-1#tw-gap-0.5#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-2#tw-gap-1#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-3#tw-gap-2#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-4#tw-gap-4#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-5#tw-gap-8#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-x-0#tw-gap-x-0#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-x-1#tw-gap-x-0.5#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-x-2#tw-gap-x-1#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-x-3#tw-gap-x-2#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-x-4#tw-gap-x-4#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-x-5#tw-gap-x-8#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-y-0#tw-gap-y-0#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-y-1#tw-gap-y-0.5#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-y-2#tw-gap-y-1#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-y-3#tw-gap-y-2#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-y-4#tw-gap-y-4#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-gap-y-5#tw-gap-y-8#g' web_src/js/**/* templates/**/*	2024-03-24 14:31:35 +00:00
silverwind	924a67c309	Remove fomantic header module (#30033) ... Likely still a few useless classes left, but I think I at least don't have missed any. --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>	2024-03-24 14:32:19 +01:00
silverwind	17855f8dc1	Replace all simple inline styles with tailwind (#30032) ... These should be all simple inline styles that were left in the templates. Co-authored-by: Giteabot <teabot@gitea.io>	2024-03-23 20:11:15 +00:00
silverwind	48fec888ee	Migrate font-weight helpers to tailwind (#30027) ... Commands ran: ```sh perl -p -i -e 's#gt-font-light#tw-font-light#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-font-normal#tw-font-normal#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-font-medium#tw-font-medium#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-font-semibold#tw-font-semibold#g' web_src/js/**/* templates/**/* perl -p -i -e 's#gt-font-bold#tw-font-bold#g' web_src/js/**/* templates/**/* ```	2024-03-23 18:45:11 +00:00
silverwind	5b9c1ba275	Fix incorrect tailwind migration (#30007) ... Fixes https://github.com/go-gitea/gitea/issues/30005. Regression from https://github.com/go-gitea/gitea/pull/29945. There was only once instance of `tw-content-center` before that PR, so I just ran below command and reverted that one instance. ```sh perl -p -i -e 's#tw-content-center#tw-items-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/* ```	2024-03-22 20:51:29 +01:00
silverwind	5cafce30c0	Replace 10 more gt- classes with tw- (#29945) ... Likely the biggest change of the tailwind refactors. Only thing of note is that `tw-flex-1` resolves to `flex: 1 1 0%` while our `gt-f1` was `flex: 1 1 0`, I don't think it will make any difference. Commands I've ran: ```sh perl -p -i -e 's#gt-vm#tw-align-middle#g' web_src/js/**/* templates/**/* models/**/* perl -p -i -e 's#gt-fw#tw-flex-wrap#g' web_src/js/**/* templates/**/* models/**/* perl -p -i -e 's#gt-f1#tw-flex-1#g' web_src/js/**/* templates/**/* models/**/* perl -p -i -e 's#gt-fc#tw-flex-col#g' web_src/js/**/* templates/**/* models/**/* perl -p -i -e 's#gt-sb#tw-justify-between#g' web_src/js/**/* templates/**/* models/**/* perl -p -i -e 's#gt-je#tw-justify-end#g' web_src/js/**/* templates/**/* models/**/* perl -p -i -e 's#gt-jc#tw-justify-center#g' web_src/js/**/* templates/**/* models/**/* perl -p -i -e 's#gt-ac#tw-content-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/* perl -p -i -e 's#gt-df#tw-flex#g' web_src/js/**/* templates/**/* models/**/* tests/**/* perl -p -i -e 's#gt-dib#tw-inline-block#g' web_src/js/**/* templates/**/* models/**/* tests/**/* Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-03-22 13:45:10 +00:00
wxiaoguang	651c2c45e7	Remove unnecessary ".Link" usages (#29909) ... In HTML, `?key=val` already means "use the current link with new query parameters"	2024-03-20 13:56:42 +08:00
wxiaoguang	72e84b02d3	Fix template error when comment review doesn't exist (#29888) ... Fix #29885	2024-03-19 04:19:48 +00:00
HEREYUA	b9180e2ccc	Improve branch select list ui in go templates (#29729) ... Relate:[#27417](https://github.com/go-gitea/gitea/issues/27471) Reference: [#26631](https://github.com/go-gitea/gitea/pull/26631) Before  After  --------- Co-authored-by: silverwind <me@silverwind.io>	2024-03-15 11:43:10 +08:00
silverwind	645e3cbc94	Add <overflow-menu>, rename webcomponents (#29400) ... 1. Add `<overflow-menu>` web component 2. Rename `<gitea-origin-url>` to `<origin-url>` and make filenames match. <img width="439" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/2fbe4ca4-110b-4ad2-8e17-c1e116ccbd74"> <img width="444" alt="Screenshot 2024-03-02 at 21 36 52" src="https://github.com/go-gitea/gitea/assets/115237/aa8f786e-dc8c-4030-b12d-7cfb74bdfd6e"> <img width="537" alt="Screenshot 2024-03-03 at 03 05 06" src="https://github.com/go-gitea/gitea/assets/115237/fddd50aa-adf1-4b4b-bd7f-caf30c7b2245">   TODO: - [x] Check if removal of `requestAnimationFrame` is possible to avoid flash of content. Likely needs a `MutationObserver`. - [x] Hide tippy when button is removed from DOM. - [x] ~~Implement right-aligned items (https://github.com/go-gitea/gitea/pull/28976)~~. Not going to do it. - [x] Clean up CSS so base element has no background and add background via tailwind instead. - [x] Use it for org and user page. --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-03-15 02:05:31 +00:00
silverwind	e95abd7c38	Replace more gt- with tw-, update frontend docs (#29595) ... Tested a few things, all working fine. Not sure if the chinese machine translation is good. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-03-05 05:29:32 +00:00
wxiaoguang	405348d244	Remove unnecessary ctxData for "attachments" template (#29600) ... The "attachments" template never uses it	2024-03-05 04:59:16 +00:00
KN4CK3R	18f708ef00	Add user blocking (#29028) ... Fixes #17453 This PR adds the abbility to block a user from a personal account or organization to restrict how the blocked user can interact with the blocker. The docs explain what's the consequence of blocking a user. Screenshots:    --------- Co-authored-by: Lauris BH <lauris@nix.lv>	2024-03-04 08:16:03 +00:00
silverwind	dc58f3c5de	Replace some gt- classes with tw- (#29570) ... Replace 18 `gt-` prefixes with `tw-` with perl replacement. I manually checked them all with `rg` afterwards.	2024-03-04 03:33:20 +00:00
wxiaoguang	b4bf78bbab	Fix incorrect redirection when creating a PR fails (#29537) ... This is only a quick fix to make it easier to backport. After this PR gets merged, I will propose a new PR to fix the FIXME. <details>  </details>	2024-03-02 12:45:14 +00:00
wxiaoguang	9de30c89f2	Fix incorrect subpath in links (#29535) ... * `$referenceUrl`: it is constructed by "Issue.Link", which already has the "AppSubURL" * `window.location.href`: AppSubURL could be empty string, so it needs the trailing slash	2024-03-02 12:02:34 +00:00
wxiaoguang	8b26e1c9b6	Refactor the "attachments" sub-template data key to RenderedContent (#29517) ... The value passed into "attachments" sub-template is from "RedneredContent", so use the same name for consistent. And it makes readers easy to know its data type.	2024-03-01 10:56:29 +00:00
wxiaoguang	7905067f1d	Refactor some Str2html code (#29397) ... This PR touches the most interesting part of the "template refactoring". 1. Unclear variable type. Especially for "web/feed/convert.go": sometimes it uses text, sometimes it uses HTML. 2. Assign text content to "RenderedContent" field, for example: ` project.RenderedContent = project.Description` in web/org/projects.go 3. Assign rendered content to text field, for example: `r.Note = rendered content` in web/repo/release.go 4. (possible) Incorrectly calling `{{Str2html .PackageDescriptor.Metadata.ReleaseNotes}}` in package/content/nuget.tmpl, I guess the name Str2html misleads developers to use it to "render string to html", but it only sanitizes. if ReleaseNotes really contains HTML, then this is not a problem.	2024-03-01 07:11:51 +00:00
Lunny Xiao	82ff1f2f15	Use tailwind instead of gt-[wh]- helper classes (#29423) ... Follow #29357 - Replace `gt-w-*` -> `tw-w-*` and remove `gt-w-*` - Replace `gt-h-*` -> `tw-h-*` and remove `gt-h-*`	2024-02-27 14:31:41 +00:00
KN4CK3R	9e71d5218f	Add missing space (#29393)	2024-02-25 15:42:36 +00:00
wxiaoguang	f33109c6ba	Remove incorrect and unnecessary Escape from templates (#29394) ... Follow #29165 * some of them are incorrect, which would lead to double escaping (eg: `(print (Escape $.RepoLink)`) * other of them are not necessary, because `Tr` handles strings&HTML automatically Suggest to review by "unified view": https://github.com/go-gitea/gitea/pull/29394/files?diff=unified&w=0	2024-02-25 14:02:20 +00:00